Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timer's params length #2655

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@justjavac
Copy link
Contributor

commented Jul 18, 2019

make web compatible

length chrome firefox
setTimeout.length 1 1
setInterval.length 1 1
clearTimeout.length 0 0
clearInterval.length 0 0
@ry

ry approved these changes Jul 18, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit ac98bd8 into denoland:master Jul 18, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@justjavac justjavac deleted the justjavac:timer-params-length branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.