Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacky normalize_path #2660

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@ry
Copy link
Collaborator

commented Jul 18, 2019

@bartlomieju
Copy link
Contributor

left a comment

There are a few more places to remove normalize_path:

  • fetch_remote_source_async
  • fetch_cached_remote_source
  • fetch_local_file

It seems code is outdated - there is no more url_to_deps_path but it appears in this PR

@ry ry force-pushed the ry:normalize_path branch from c2fcc0f to c4e1799 Jul 18, 2019

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 18, 2019

@bartlomieju Yea I stupidly did this patch not on master at first. Re-did it now.

@ry ry requested a review from piscisaureus Jul 18, 2019

@piscisaureus
Copy link
Collaborator

left a comment

Yup, excellent

@ry ry merged commit a37bc00 into denoland:master Jul 18, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.