Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL shouldn't crash when it gets SIGINT #2662

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@ry
Copy link
Collaborator

commented Jul 18, 2019

Fixes #2653

I wasn't able to come up with a good test for this. tools/repl_test.py, I discovered isn't really testing the REPL exactly because the stdio pipes it sets up are not TTYs. So the test behavior is different than a real REPL session. I will address this later.

@ry ry force-pushed the ry:repl_ctrl_c branch from 6dd636c to c5d7efe Jul 18, 2019

@ry ry requested a review from piscisaureus Jul 18, 2019

@ry ry merged commit 55ca0f0 into denoland:master Jul 18, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.