Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove v8::Locker from deno_respond #2664
ry left a comment
LGTM - if it passes the tests it's fine by me. Thanks!
(It's possible this may introduce a segfault somewhere, but if so it's something we should be testing for. They're relatively easy crashes to figure out with a debug build.)
Also for this one: https://github.com/denoland/deno/blob/master/core/isolate.rs#L554
Also I think
@kevinkassimo The idea is that during poll we're calling into JS many times, so it's better to acquire the lock one for all of them rather than in each individual call.
(Looking at the Rust code now, I worry that the Rust compiler might try to free _locker before poll completes. Probably we should add