Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use Locker when calling into JS #2665

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@afinch7
Copy link
Contributor

commented Jul 18, 2019

@ry

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2019

Hmm good point. But dyn_import_done also calls into JS.

cc @piscisaureus

@afinch7

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@ry dyn_import_done uses Locker on the c++ side.

@ry

ry approved these changes Jul 19, 2019

Copy link
Collaborator

left a comment

LGTM ok let's try it

@ry ry merged commit 621af21 into denoland:master Jul 19, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@ry

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Maybe that was better. It's very marginal but it is the highest req/sec yet for deno_tcp

Screen Shot 2019-07-18 at 9 28 52 PM

@ry

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

The benefit to deno_tcp didn't pan out, the above peak was just noise. I'm now concerned that this patch actually caused a slow down. It's too soon to tell, but deno_core_single seems to be slower...

Screen Shot 2019-07-22 at 9 52 02 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.