Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website/benchmark): enable zoom of charts #2668

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@kt3k
Copy link
Contributor

commented Jul 19, 2019

This enables the zooming of charts of the benchmark page by mouse wheel (scrolling) event. It's a little slow when showing all benchmark data, but it still works.

closes #2666

@kt3k kt3k force-pushed the kt3k:feature/zoom branch 2 times, most recently from 6d9145b to fd45d27 Jul 19, 2019

@kt3k kt3k force-pushed the kt3k:feature/zoom branch from fd45d27 to 78f9ab9 Jul 19, 2019

@ry

ry approved these changes Jul 21, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 9c22961 into denoland:master Jul 21, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/zoom branch Jul 22, 2019

@kt3k

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

Thank you for clearing the CI status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.