Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo_gn to build using "cargo build" #2675

Open
wants to merge 2 commits into
base: master
from

Conversation

@ry
Copy link
Collaborator

commented Jul 22, 2019

depends on #2740

@ry ry referenced this pull request Jul 22, 2019
0 of 2 tasks complete
# clang-cl: error: argument unused during compilation:
# '-mno-incremental-linker-compatible'
# [-Werror,-Wunused-command-line-argument]
treat_warnings_as_errors = false

This comment has been minimized.

Copy link
@chrmoritz

chrmoritz Jul 22, 2019

Contributor

Also this happens only when using sccache (it doesn't happen when calling clang-cl directly). Maybe related: mozilla/sccache#264

https://ci.appveyor.com/project/chrmoritz/deno/builds/26385484 (without this workaround, but without using sccache: chrmoritz@388b738).

@afinch7 afinch7 referenced this pull request Jul 30, 2019

@ry ry requested a review from piscisaureus Jul 31, 2019

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 1, 2019

The biggest problem currently is that cargo build rebuilds every time...

> make -f target/debug/deno.d -d  | grep newer
 Prerequisite `/Users/rld/src/deno/core/js_errors.rs' is newer than target `/Users/rld/src/deno/target/debug/deno.dSYM'.
 Prerequisite `/Users/rld/src/deno/target/debug/gn_out/../../../core/libdeno/deno.h' is newer than target `/Users/rld/src/deno/target/debug/deno.dSYM'.
 Prerequisite `/Users/rld/src/deno/target/debug/gn_out/gen/cli/snapshot_compiler.bin' is newer than target `/Users/rld/src/deno/target/debug/deno.dSYM'.
 Prerequisite `/Users/rld/src/deno/target/debug/gn_out/gen/cli/snapshot_deno.bin' is newer than target `/Users/rld/src/deno/target/debug/deno.dSYM'.

I believe I've found the source of the problem tho...

@ry ry force-pushed the cargo_gn2 branch from 5765cbe to fb87a7c Aug 6, 2019

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 6, 2019

Incremental build is working for me now if I unset RUSTC_WRAPPER in my env
cc @piscisaureus

@ry ry force-pushed the cargo_gn2 branch from 23c3f17 to aff3114 Aug 22, 2019

@ry ry requested review from piscisaureus and removed request for piscisaureus Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.