Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save headers for all intermediate redirects #2677

Merged
merged 8 commits into from Jul 22, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Jul 22, 2019

Closes #2656

bartlomieju added some commits Jul 20, 2019

@ry
Copy link
Collaborator

left a comment

I have confirmed that test_get_source_code_5 fails on master.

cli/deno_dir.rs Outdated Show resolved Hide resolved
cli/deno_dir.rs Outdated Show resolved Hide resolved
cli/deno_dir.rs Outdated Show resolved Hide resolved
cli/deno_dir.rs Outdated Show resolved Hide resolved
deno_dir.fetch_remote_source(&double_redirect_url, false, false, 1);
assert!(result.is_err());

// TODO: add better tests

This comment has been minimized.

Copy link
@ry

ry Jul 22, 2019

Collaborator

This isn't an actionable TODO. Be more specific. (Unless it's part of your WIP and will be removed before landing.)

This comment has been minimized.

Copy link
@bartlomieju

bartlomieju Jul 22, 2019

Author Contributor

Ooops, missed that one. Fixed

@ry

ry approved these changes Jul 22, 2019

Copy link
Collaborator

left a comment

LGTM - nice clean up!

@ry ry merged commit 70de8dd into denoland:master Jul 22, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:cache_redirect_handling branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.