Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for dynamic imports to libdeno #2678

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@ry
Copy link
Collaborator

commented Jul 23, 2019

No description provided.

@piscisaureus piscisaureus force-pushed the ry:libdeno_dyn_import_errors branch 2 times, most recently from 92f5e59 to e3069aa Jul 23, 2019

Show resolved Hide resolved core/isolate.rs
Show resolved Hide resolved core/libdeno/exceptions.cc
@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 23, 2019

LGTM

@piscisaureus piscisaureus force-pushed the ry:libdeno_dyn_import_errors branch from dc9e58a to 1406961 Jul 23, 2019

@piscisaureus piscisaureus changed the title WIP Better error handling in libdeno for dyn imports Add error handling for dynamic imports to libdeno Jul 24, 2019

@piscisaureus piscisaureus merged commit 1406961 into denoland:master Jul 24, 2019

3 of 4 checks passed

Travis CI - Branch Build Created
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry referenced this pull request Aug 1, 2019

Open

Support dynamic import #1789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.