Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: handle deno -v and deno --version #2684

Merged
merged 2 commits into from Jul 27, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Jul 26, 2019

Closes #2652

@bartlomieju bartlomieju force-pushed the bartlomieju:cli-version_flag branch from 04d2b27 to f1c38c2 Jul 26, 2019

Show resolved Hide resolved cli/flags.rs Outdated
assert_eq!(subcommand, DenoSubcommand::Version);
assert_eq!(argv, svec!["deno"]);

let (flags, subcommand, argv) = flags_from_vec(svec!["deno", "-v"]);

This comment has been minimized.

Copy link
@ry

ry Jul 27, 2019

Collaborator

👍

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2019

@ry updated

@ry

ry approved these changes Jul 27, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 89e6792 into denoland:master Jul 27, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:cli-version_flag branch Jul 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.