Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: bundle size #2690

Merged
merged 4 commits into from Jul 28, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Jul 27, 2019

Closes #2575

def bundle_benchmark(deno_exe):
bundles = {
"file_server": "https://deno.land/std/http/file_server.ts",
"gist": "https://deno.land/std/examples/gist.ts",

This comment has been minimized.

Copy link
@bartlomieju

bartlomieju Jul 27, 2019

Author Contributor

It probably makes sense to use version tagged version of URLs, otherwise benchmark will fluctuate with changes to them.

bartlomieju added some commits Jul 27, 2019

@ry

ry approved these changes Jul 28, 2019

Copy link
Collaborator

left a comment

Cool! I think it’s better to use master branch for the bundles actually - because then we will notice if there is bloat being added inside of deno_std.

LGTM

(It’ll take me a day or so before I can upload this to the website)

@ry ry merged commit 187310a into denoland:master Jul 28, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:benchmark-bundle_size branch Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.