Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap stack traces of unthrown errors. #2693

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@kitsonk
Copy link
Contributor

commented Jul 28, 2019

This is a redone PR of a previous one that works with current Deno. In the previous PR I had hoped to move the cache of the parsed source maps into Deno cache, but I think it is just better to iterate on that eventually when deno_dir settles down.

Fixes #1717

@kitsonk kitsonk force-pushed the kitsonk:remap-unthrown-2 branch from e5f829c to 532e2c5 Jul 28, 2019

@ry

ry approved these changes Jul 29, 2019

Copy link
Collaborator

left a comment

LGTM - no comments!

});
assert(result.filename.startsWith("js/"));
assert(result.line != null);
assert(result.column != null);

This comment has been minimized.

Copy link
@ry

ry Jul 29, 2019

Collaborator

👍

* });
* console.log(`${orig.filename}:${orig.line}:${orig.column}`);
*
*/

This comment has been minimized.

Copy link
@ry

ry Jul 29, 2019

Collaborator

👍

at [WILDCARD]tests/error_stack.ts:6:3
error: Uncaught Error: foo
at foo ([WILDCARD]tests/error_stack.ts:2:9)
at [WILDCARD]tests/error_stack.ts:6:3

This comment has been minimized.

Copy link
@ry

ry Jul 29, 2019

Collaborator

👍

@ry ry merged commit 5083f5f into denoland:master Jul 29, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.