Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add debug info to ModuleResolutionError #2697

Merged

Conversation

@bartlomieju
Copy link
Contributor

commented Jul 30, 2019

A little ergonomic change, with it should be easier to spot bad imports.

Before:

Compile file:///Users/biwanczuk/dev/deno/tests/error_011_bad_module_specifier.ts
error: Uncaught ImportPrefixMissing: relative import path not prefixed with / or ./ or ../
...snip...

After:

Compile file:///Users/biwanczuk/dev/deno/tests/error_011_bad_module_specifier.ts
error: Uncaught ImportPrefixMissing: relative import path "bad-module.rs" not prefixed with / or ./ or ../
...snip...

Also closes #2402

@ry

ry approved these changes Jul 30, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit ac269be into denoland:master Jul 30, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:feat-module_resolution_error_debug_info branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.