Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce env permission on homeDir() and execPath #2714

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@kevinkassimo
Copy link
Contributor

commented Aug 3, 2019

Closes #2713 .

Turning on allow_env check for Deno.homeDir().
Also set Deno.execPath to empty string if env is not turned on.

@ry

ry approved these changes Aug 4, 2019

Copy link
Collaborator

left a comment

LGTM - WB

@ry ry merged commit 52c13fb into denoland:master Aug 4, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@piscisaureus piscisaureus referenced this pull request Aug 9, 2019

Merged

v0.14.0 #2754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.