Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce run permission on kill() #2723

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@nayeemrmn
Copy link
Contributor

commented Aug 4, 2019

Closes #2722

@ry
Copy link
Collaborator

left a comment

Can you add this requirement to the jsdoc comment for kill ?

—allow-run is broad for kill- but it’s better than nothing. Adding an allow-kill seems unnecessarily specific.

@nayeemrmn

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

Done. Did the env ones as well, since Deno.homeDir()'s was wrong and Deno.execPath's permission-less behaviour isn't obvious.

@nayeemrmn nayeemrmn force-pushed the nayeemrmn:kill-permissions branch 2 times, most recently from 007ab48 to d968a91 Aug 4, 2019

@nayeemrmn nayeemrmn force-pushed the nayeemrmn:kill-permissions branch 2 times, most recently from 76a35c6 to b76fc8a Aug 6, 2019

@ry

ry approved these changes Aug 6, 2019

Copy link
Collaborator

left a comment

LGTM

see #2733 also

@ry ry merged commit 11c850a into denoland:master Aug 6, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@nayeemrmn nayeemrmn deleted the nayeemrmn:kill-permissions branch Aug 6, 2019

@piscisaureus piscisaureus referenced this pull request Aug 9, 2019

Merged

v0.14.0 #2754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.