Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deno.build.args feature #2728

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@ry
Copy link
Collaborator

commented Aug 5, 2019

This is a minor feature which complicates the build signifigantly.
Removing to ease refactoring the build system:
#2608

cc @kt3k

Remove Deno.build.args feature
This is a minor feature which complicates the build signifigantly.
Removing to ease refactoring the build system:
#2608

@ry ry requested a review from piscisaureus Aug 5, 2019

@piscisaureus
Copy link
Collaborator

left a comment

lgtm

@ry ry merged commit a517513 into denoland:master Aug 5, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@kt3k

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

I thought creating a GN entry for a single command and single text file was overkill. (and GN didn't seem supporting such situation effectively) I would try calling the command directly from where it's needed if we try similar thing next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.