Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Blob url support for worker #2729

Merged
merged 2 commits into from Aug 6, 2019

Conversation

@kevinkassimo
Copy link
Contributor

commented Aug 5, 2019

Related to #2726

Support worker creation using Blob URL.

Notice that it does not support static import statements (It seems to me that Chrome also does not support it with both blob url and data url?)

(Data URL version is left to implement later since there are more complications involved)

kevinkassimo added some commits Aug 5, 2019

@@ -63,6 +66,20 @@ function parse(url: string): URLParts | undefined {
return undefined;
}

// Based on https://github.com/kelektiv/node-uuid
// TODO(kevinkassimo): Use deno_std version once possible.

This comment has been minimized.

Copy link
@ry

ry Aug 6, 2019

Collaborator

👍
I think I now have an ideas now on how to use deno_std well (#2711)

@@ -0,0 +1 @@
code from Blob

This comment has been minimized.

Copy link
@ry

ry Aug 6, 2019

Collaborator

cool.

@ry

ry approved these changes Aug 6, 2019

Copy link
Collaborator

left a comment

LGTM - no comments

@ry ry merged commit ccee2f0 into denoland:master Aug 6, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@piscisaureus piscisaureus referenced this pull request Aug 9, 2019

Merged

v0.14.0 #2754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.