Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Deno.execPath a function #2743

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@kevinkassimo
Copy link
Contributor

commented Aug 6, 2019

Closes #2733

Need to update deno_std as well

@ry

ry approved these changes Aug 6, 2019

Copy link
Collaborator

left a comment

LGTM - thanks!

@ry ry merged commit 4519f9a into denoland:master Aug 6, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@nayeemrmn
Copy link
Contributor

left a comment

I'm a bit late, sorry.

const path = res.path();

if (!path) {
throw new Error("Could not get home directory.");

This comment has been minimized.

Copy link
@nayeemrmn

nayeemrmn Aug 6, 2019

Contributor

Wrong error message.

@@ -164,3 +158,19 @@ export function homeDir(): string {

return path;
}

This comment has been minimized.

Copy link
@nayeemrmn

nayeemrmn Aug 6, 2019

Contributor

JSDoc.

@piscisaureus piscisaureus referenced this pull request Aug 9, 2019

Merged

v0.14.0 #2754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.