Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle tsconfig.json with comments #2773

Merged
merged 3 commits into from Aug 17, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Aug 13, 2019

Closes #2765

This PR removes parsing JSON file in Rust and instead uses regex to look for "checkJs": true.

Regex will capture following combinations:

"checkJs":true,

"checkJs": true,

"checkJs":
true,

"checkJs"
: true,
cli/compilers/ts.rs Outdated Show resolved Hide resolved
tests/038_checkjs_commented_json.tsconfig.json Outdated Show resolved Hide resolved
cli/compilers/ts.rs Outdated Show resolved Hide resolved
@ry

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2019

Sorry if this is a dumb question, but why do we need to have check_js extracted again?

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

@ry
ry approved these changes Aug 17, 2019
Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 4faab6a into denoland:master Aug 17, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:fix-invalid_json_in_tsconfig branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.