Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set url property of fetch's response #2782

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@kt3k
Copy link
Contributor

commented Aug 15, 2019

This PR sets url property of response object.

closes #2781

@kt3k kt3k force-pushed the kt3k:feature/response-url branch 3 times, most recently from 3f4601b to 3121116 Aug 15, 2019

@kt3k kt3k force-pushed the kt3k:feature/response-url branch from 3121116 to 66dfa99 Aug 15, 2019

@kt3k

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

deno bundle https://deno.land/std/http/file_server.ts seems stuck with this change in travis... 🤔

Update: After a few (3-4) retries, the above problem disappeared.

@ry

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

Hm. I think it might be related to 498f6ad

Maybe readSync/writeSync need to use tokio_util::block_on() instead of wait() ?

@kt3k

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

The above bundle command causes Segmentation fault only when built in release mode... (on my mac)

$ ./target/debug/deno bundle https://deno.land/std/http/file_server.ts
Bundling "file_server.bundle.js"
Emitting bundle to "file_server.bundle.js"
517.7 kB emitted.
$ ./target/release/deno bundle https://deno.land/std/http/file_server.ts
Bundling "file_server.bundle.js"
Emitting bundle to "file_server.bundle.js"
Segmentation fault: 11

(Note: The same thing happens with master)

@ry ry referenced this pull request Aug 16, 2019
@ry
ry approved these changes Aug 16, 2019
Copy link
Collaborator

left a comment

LGTM - thanks

@ry ry merged commit 9aa9aaf into denoland:master Aug 16, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/response-url branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.