Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start porting flatbuffer ops to JSON #2799

Merged
merged 9 commits into from Aug 23, 2019

Conversation

@ry
Copy link
Collaborator

commented Aug 21, 2019

ref #2121

depends on #2796

next pr contains some examples of ops that have been ported #2802

@ry ry force-pushed the ry:json_ops branch from 861603b to 83f53e2 Aug 21, 2019

@ry ry closed this Aug 21, 2019

@ry ry reopened this Aug 21, 2019

@ry ry force-pushed the ry:json_ops branch 2 times, most recently from 2774da2 to 90c00ec Aug 21, 2019

@ry ry requested a review from piscisaureus Aug 21, 2019

Add ability to dispatch ops using JSON
Converts env(), exit(), execPath(), utime() and utimeSync() to use JSON
instead of flatbuffers.

@ry ry force-pushed the ry:json_ops branch from 90c00ec to 846d91b Aug 22, 2019

@ry ry force-pushed the ry:json_ops branch 2 times, most recently from 28f7778 to 846d91b Aug 22, 2019

@ry ry referenced this pull request Aug 22, 2019
ry added 2 commits Aug 22, 2019
@romainPrignon romainPrignon referenced this pull request Aug 22, 2019
ry added 3 commits Aug 22, 2019
js/utime.ts Show resolved Hide resolved
@@ -37,7 +37,7 @@ regex = "1.2.1"
remove_dir_all = "0.5.2"
ring = "~0.14.6"
rustyline = "5.0.2"
serde = "1.0.99"
serde = { version = "1.0.99", features = ["derive"] }

This comment has been minimized.

Copy link
@piscisaureus

piscisaureus Aug 22, 2019

Collaborator

Do this as a separate PR, so we can keep the cargo an gn builds in sync.

This comment has been minimized.

Copy link
@piscisaureus
ry added 2 commits Aug 23, 2019

@ry ry merged commit bc467b2 into denoland:master Aug 23, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the ry:json_ops branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.