Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port ops to JSON (fs) #2812

Merged
merged 5 commits into from Aug 26, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Aug 24, 2019

This PR ports remaining fs ops to JSON dispatch

@bartlomieju bartlomieju force-pushed the bartlomieju:port_fs_ops_to_json branch from 07c0d08 to 6ce3816 Aug 24, 2019

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

@ry rebased on top of master. I'm gonna skip fine-trim of msg.fbs for now, once op_read and op_write use minimal dispatch for sync ops whole file can be deleted

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

Blocked by #2815 and #2816

@bartlomieju bartlomieju force-pushed the bartlomieju:port_fs_ops_to_json branch from 7b9d07f to 6ce3816 Aug 25, 2019

bartlomieju added 2 commits Aug 26, 2019
@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@ry this PR should be landable now, wrapping up transition to JSON ops

@ry
ry approved these changes Aug 26, 2019
Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit a6f6209 into denoland:master Aug 26, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:port_fs_ops_to_json branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.