Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back json ops #2815

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Aug 25, 2019

Ref: #2814

Revert "Revert json ops (#2814)"
This reverts commit 2235dd7.
@ry

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2019

I’d rather land a fix and test to the shared_queue and then bring back the ops in a separate commit.

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

@ry agreed, I'm trying to verify that this is indeed a viable solution

@bartlomieju bartlomieju force-pushed the bartlomieju:bring_back_json_ops branch from 2ccbcf1 to 641a537 Aug 25, 2019

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

This PR should be landed after #2816

@bartlomieju bartlomieju referenced this pull request Aug 25, 2019
@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@ry problem with benchmarks no longer occurs

@ry

This comment has been minimized.

Copy link
Collaborator

commented Aug 26, 2019

@bartlomieju Cool - this contains all of your changes that were reverted, and this is ready to land?

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@ry yes, I reverted the "revert" commit, it's ready to land

@ry
ry approved these changes Aug 26, 2019
Copy link
Collaborator

left a comment

LGTM - round 2!

@ry ry merged commit 520f963 into denoland:master Aug 26, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:bring_back_json_ops branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.