Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port readSync/writeSync ops to minimal dispatch #2817

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@ry
Copy link
Collaborator

commented Aug 26, 2019

@ry ry force-pushed the ry:sync_read_write branch from 14aab53 to 7ec6655 Aug 26, 2019

Port readSync/writeSync ops to minimal
This removes dispatch_flatbuffers as it is now unused. There are still a
few places where msg_generated is used: ErrorKind and MediaType. These
will be dealt with later.

@ry ry force-pushed the ry:sync_read_write branch from 7ec6655 to 73e1354 Aug 26, 2019

@ry ry requested a review from piscisaureus Aug 26, 2019

@ry ry referenced this pull request Aug 26, 2019
@bartlomieju
Copy link
Contributor

left a comment

Yes! 🎉

@piscisaureus
Copy link
Collaborator

left a comment

😎

@ry ry merged commit d8ada4d into denoland:master Aug 26, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.