Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flatbuffers #2818

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@ry
Copy link
Collaborator

commented Aug 26, 2019

Depends on #2817

Fixes #2121

@bartlomieju

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Great to finally have it removed! @ry what's your idea to handle ErrorKind and MediaType? Keeping them in sync between Rust and TypeScript manually seems like a low hanging fruit for now.

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 26, 2019

@bartlomieju Not sure yet how best to handle ErrorKind and MediaType. Maybe we need something like #[derive(TypeScript)]. I'm fine with manually keeping them in sync in the near term tho.

@ry ry requested a review from piscisaureus Aug 26, 2019

@ry ry force-pushed the ry:remove_flatbuffers branch 2 times, most recently from 97b7881 to c7b4c6e Aug 26, 2019

@ry ry force-pushed the ry:remove_flatbuffers branch from c7b4c6e to 3cf9239 Aug 26, 2019

@rw

This comment has been minimized.

Copy link

commented Aug 26, 2019

I agree that this is the right move :-] Deno doesn't need most of the features FlatBuffers provides, and replacing your serialization system with an i8 enum is going to be orders of magnitude faster.

@piscisaureus
Copy link
Collaborator

left a comment

reviewed, LGTM

@ry ry merged commit f949004 into denoland:master Aug 26, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.