Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up various flatbuffer references #2819

Merged
merged 3 commits into from Aug 27, 2019

Conversation

@ry
Copy link
Collaborator

commented Aug 26, 2019

@ry ry requested a review from piscisaureus Aug 26, 2019

@ry ry force-pushed the ry:fbs_cleanup branch from 710b6b9 to 68ca2b1 Aug 26, 2019

ry added 2 commits Aug 26, 2019
@piscisaureus
Copy link
Collaborator

left a comment

utils.rs removal seems unrelated. Make/keep it as a separate commit.

@@ -10,9 +10,6 @@
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"noUnusedLocals": true,
"paths": {
"*": ["*", "target/debug/*", "target/release/*"]
},

This comment has been minimized.

Copy link
@ry

ry Aug 26, 2019

Author Collaborator

@kitsonk This is ok, right?

This comment has been minimized.

Copy link
@kitsonk

kitsonk Aug 27, 2019

Contributor

Yes, as we don't have to go find the generated msg anymore.

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 26, 2019

@piscisaureus utils.rs are flatbuffer message utils

@kitsonk
Copy link
Contributor

left a comment

LGTM

@ry ry merged commit 725eb98 into denoland:master Aug 27, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the ry:fbs_cleanup branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.