Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize base64-js, convert to TypeScript #2826

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@ry
Copy link
Collaborator

commented Aug 28, 2019

As we improve our core bundling process, we will not be able to rely on external NPM modules.

Luckily there are only three of them:

  • base64-js, which I've ported to TS and internalized in this PR.
  • @standarized/streams, which I will rip out and introduce regressions in this PR. (cc @mrkurt)
  • typescript, which will be specially handled.

Towards #2608

@ry ry force-pushed the ry:simplify_deps branch 4 times, most recently from e01226b to 10a49bb Aug 28, 2019

ry added 2 commits Aug 28, 2019
Remove @stardazed/streams
This is a regression on several some features in the fetch API. To bring
these back @stardazed/streams simply needs to be ported to TS and
included in the //js directory.

Towards #2608

@ry ry force-pushed the ry:simplify_deps branch from 10a49bb to d7708b2 Aug 28, 2019

@mrkurt

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

I'm happy to help with streams, do you know how you want to handle those?

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 28, 2019

@mrkurt Cool - so basically we just need to move it into //js rather than have it in node_modules... but the problem is I don't have support for /// <reference types="..."/>, so we need a streams.ts file which includes the TS and JS. Or, I need to add /// <reference types="..."/> support to https://github.com/ry/deno_typescript .... I think porting streams to typescript is the best route for now.

I added an issue for this #2828

@ry ry requested a review from piscisaureus Aug 28, 2019

@ry ry merged commit 8f91946 into denoland:master Aug 28, 2019

3 of 4 checks passed

Travis CI - Pull Request Build Created
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the ry:simplify_deps branch Aug 28, 2019

@mrkurt

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

Oh, probably don't even need a port, they're already typescript! https://github.com/stardazed/sd-streams/tree/master/packages/streams/src

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.