Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/build.py #2865

Merged
merged 18 commits into from Sep 7, 2019

Conversation

@ry
Copy link
Collaborator

commented Sep 5, 2019

Fixes #2608

Issues:

  • Doesn't run libdeno_test
  • This removes the ASAN build.
  • //BUILD.gn and //build are still in place. GN/Ninja should be limited to //core or //core/libdeno
ry added 5 commits Sep 5, 2019
wip
WIP
WIP
rm -rf third_party/rust_crates
This removes a lot of code...

 4920 files changed, 1925152 deletions(-)

@ry ry requested a review from piscisaureus Sep 5, 2019

ry added 9 commits Sep 5, 2019
fix
core/build.rs Show resolved Hide resolved
ry added 4 commits Sep 6, 2019
@piscisaureus
Copy link
Collaborator

left a comment

LGTM to land this.
Future improvements van be done in separate PRs.

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 7, 2019

Alright - let’s do it! Good bye build.py

@ry ry merged commit acaff6d into denoland:master Sep 7, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.