Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade V8 to 7.9.8 #2907

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@ry
Copy link
Collaborator

commented Sep 10, 2019

//build was updated and our patch rebased:
https://github.com/denoland/chromium_build/tree/20190910_win_clang_depfile

V8 has removed the binaries third_party/v8/buildtools/*/gn.sha1
I'm not sure where they moved them too, so I've hacked it and left them.

ry added 3 commits Sep 10, 2019
//build was updated and our patch rebased:
https://github.com/denoland/chromium_build/tree/20190910_win_clang_depfile

V8 has removed the binaries third_party/v8/buildtools/*/gn.sha1
I'm not sure where they moved them too, so I've hacked it and left them.
@chrmoritz

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

V8 has removed the binaries third_party/v8/buildtools/*/gn.sha1
I'm not sure where they moved them too, so I've hacked it and left them.

I think they are moving away from their download_from_google_storage tooling and migrating the binaries to CIPD (their own binary packet manager): https://github.com/v8/v8/blob/7.9.8/DEPS#L29-L30

see also the upstream commit which migrated gn to CIPD: https://chromium.googlesource.com/chromium/src/buildtools/+/c79f3482c8152172a31e5c17823a27835a511dac%5E%21/#F1

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2019

@chrmoritz Thanks for the info. Do you know if there's a command we can run to download CIPD binaries?

@ry ry force-pushed the upgrade_v8 branch from 3e2b8c7 to aa2313d Sep 10, 2019
@ry ry force-pushed the upgrade_v8 branch from aa2313d to d9e146d Sep 10, 2019
@chrmoritz

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

@ry: cipd is part of depot_tools just like download_from_google_storage

you can then run

path/to/depot_tools/cipd install gn/gn/{windows,mac,linux}-amd64 git_revision:152c5144ceed9592c20f0c8fd55769646077569b

to install gn to the current working directory (or optionally pass -root path/to/install_dir) and take the git_revision: version from the DEPS file

Edit: I'm currently looking how to integrate this into tools/third_party.py, but it seems that your copy of depot_tools in deno_third_party is too old.

chrmoritz@3d58993

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2019

@chrmoritz Thanks, I'll make that change in a later PR

@ry ry requested a review from piscisaureus Sep 10, 2019
Copy link
Collaborator

left a comment

💞

@ry ry merged commit dd70d86 into master Sep 10, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@ry ry deleted the upgrade_v8 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.