Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default base URL path to '/' #2921

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@nayeemrmn
Copy link
Contributor

commented Sep 11, 2019

resolvePathFromBase() uses the base URL path with the expectation of this default.

@nayeemrmn nayeemrmn force-pushed the nayeemrmn:url-patch branch from c62842f to ae79523 Sep 11, 2019
@nayeemrmn nayeemrmn changed the title Default internal URL path to '/' Default base URL path to '/' Sep 11, 2019
@nayeemrmn nayeemrmn force-pushed the nayeemrmn:url-patch branch from ae79523 to 1c16345 Sep 11, 2019
@ry
ry approved these changes Sep 11, 2019
Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit ad11f2a into denoland:master Sep 11, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@nayeemrmn nayeemrmn deleted the nayeemrmn:url-patch branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.