Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump prettier revision #2928

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Sep 12, 2019

This PR bumps revision of prettier after landing denoland/deno_std#592. It means that now type definitions will be parsed instead of big parser files.

Fixes #2490 馃帀

@ry
ry approved these changes Sep 12, 2019
Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit a8f4421 into denoland:master Sep 12, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bartlomieju bartlomieju deleted the bartlomieju:patch-4 branch Sep 12, 2019
@ry

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

This patch was a major improvement in speed for TestFmt. It went from 6 minutes (!!!) to 1.6 minutes.

I think we can still do better if we can solve #2626

Before:

> cargo build && ./tools/test.py -p fmt
   Compiling deno_cli v0.17.0 (/Users/rld/src/deno/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 18.84s
fmt (fmt_test.TestFmt) ... ok

----------------------------------------------------------------------
Ran 1 test in 362.475s

OK

After:

> cargo build && ./tools/test.py -p fmt
   Compiling deno_cli v0.17.0 (/Users/rld/src/deno/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 34.59s
fmt (fmt_test.TestFmt) ... ok

----------------------------------------------------------------------
Ran 1 test in 95.428s

OK
@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

I think we can still do better if we can solve #2626

@ry partially, the best we can do is download all imports from single file at once (which should still gives us a nice speed gain)

@bartlomieju bartlomieju referenced this pull request Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can鈥檛 perform that action at this time.