Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 0.0.0.0 for servers in benchmarks and tests #3010

Merged
merged 10 commits into from Sep 30, 2019

Conversation

@ry
Copy link
Collaborator

commented Sep 23, 2019

This is preliminary work for supporting benchmarks on github actions (#3008)

ry added 10 commits Sep 23, 2019
x
fix
fix
fix
fix
@ry ry requested a review from piscisaureus Sep 26, 2019
@piscisaureus

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

No objections to this. But why is it necessary? does listening on localhost somehow not work on github?

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

No objections to this. But why is it necessary? does listening on localhost somehow not work on github?

AFAICT that is the problem... Maybe they have some stricter firewall rules?

@ry ry merged commit 5f7ab48 into denoland:master Sep 30, 2019
7 checks passed
7 checks passed
Build and test for ubuntu-latest
Details
lint
Details
Build and test for windows-2016
Details
Build and test for macOS-latest
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@ry ry deleted the ry:bench_addr_any branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.