Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support top-level-await in TypeScript #3024

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@ry
Copy link
Collaborator

commented Sep 26, 2019

Fixes #471

After this we should clean up the documentation...

@ry ry requested a review from piscisaureus Sep 26, 2019
@ry ry force-pushed the ry:top_level_await_ts branch from 6221531 to 5b20b83 Sep 26, 2019
@kitsonk

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2019

TLA for TypeScript is scheduled for 3.7, planned for Nov 7th.

Refs: microsoft/TypeScript#33352 and microsoft/TypeScript#25988

Copy link
Collaborator

left a comment

I am expecting many subtle bugs in our top level await support.
E.g. certain type checks that typescript will get wrong, module initialization in the wrong order / racy, etc.

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

I am expecting many subtle bugs in our top level await support. E.g. certain type checks that typescript will get wrong, module initialization in the wrong order / racy, etc.

I wouldn't be surprised either - but some preliminary checks I did with TLA + type errors did report the correct error. But this is just a bandaid until TypeScript properly parses TLA.

@ry ry merged commit ae26a9c into denoland:master Sep 30, 2019
7 checks passed
7 checks passed
Build and test for ubuntu-latest
Details
lint
Details
Build and test for windows-2016
Details
Build and test for macOS-latest
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@ry ry deleted the ry:top_level_await_ts branch Sep 30, 2019
@hayd

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2019

Is top level for-await a distinct typescript/V8 issue?

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

@hayd yes - it’s not yet supported in v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.