Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust stable to 1.38.0 #3030

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@hayd
Copy link
Contributor

commented Sep 26, 2019

Note: This addresses all but one of the new clippy errors, I think this one remains:

EDIT: I addressed the last clippy issue using match if.

@hayd

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

The build error looks to be an update required for sccache (that fixed mozilla/sccache#488).

@ry

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

Upgrading sccache in #3051 - will try this once it's landed.

@ry
ry approved these changes Oct 3, 2019
Copy link
Collaborator

left a comment

LGTM - thanks @hayd

@ry ry merged commit f7bbd71 into denoland:master Oct 3, 2019
8 checks passed
8 checks passed
test macOS-10.14
Details
lint
Details
test windows-2016
Details
test ubuntu-16.04
Details
bench ubuntu-16.04
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.