Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
perf: eager poll async ops in Isolate #3046
Revamp of #2779 with new dispatcher infra.
I get ridiculous result on my machine...
That's ~90% increase for debug and ~20% for release. You can see that latency got worse, but that's promising results.
Latest benchmarks from my machine:
Current thread runtime
piscisaureus left a comment •
Approving because I want to see the benchmark results.
Very nice work @bartlomieju! This PR has proven significant perf gains in the http server benchmark and throughput benchmark:
It's worth noting that our benchmark page is generated inside Github Actions, which are perhaps not the best servers to undertake CPU heavy measurements. On the benchmarks page, deno_tcp is shown as performing better than node_tcp. On my own machine, when I benchmark them, node_tcp is still significantly better:
So there is still work to do. We will be able to upgrade to Tokio's new scheduler in the coming weeks, which should shed some light on how much of this overhead is due to our dependencies.