Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't build while linting and try to publish in forks #3070

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@chrmoritz
Copy link
Contributor

commented Oct 5, 2019

This PR fixes 2 smaller issues with the gh action CI:

  • don't try (and fail) to publish (benchmarks or releases on tag pushes) when running in a fork (reported by @nayeemrmn in gitter)
  • don't build in the lint job (could safe some time to get faster linting results)
@chrmoritz chrmoritz force-pushed the chrmoritz:patch-1 branch from 43a8e98 to bc85a8b Oct 5, 2019
@ry
ry approved these changes Oct 5, 2019
Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 351d40e into denoland:master Oct 5, 2019
6 checks passed
6 checks passed
test macOS-10.14
Details
test windows-2016
Details
test ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.