Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor benchmark results posting #3076

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@chrmoritz
Copy link
Contributor

commented Oct 6, 2019

Fixes: #3062
Continuation of: #3071

This PR moves the 'checking out the old historic benchmark data' from benchmark.py to a much later point in the gh action script, which should significantly reduce the likelihood of race conditions as described in #3062.

This also moves the merging of new benchmark results into the all data.json into a separated file, called in CI directly after checking out gh-pages and directly before pushing the new data to it. It should be also slightly more robust against gh-pages checkout failures, because it fails now the build instead of silently starting with an empty array in such cases as before.

@ry
ry approved these changes Oct 6, 2019
Copy link
Collaborator

left a comment

I think this is a very helpful conceptual clean up

LGTM

@ry ry merged commit 3e02d7d into denoland:master Oct 6, 2019
6 checks passed
6 checks passed
test macOS-10.14
Details
test windows-2016
Details
test ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.