Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Move fs/path to the top-level #3100

Merged
merged 5 commits into from Oct 16, 2019

Conversation

@nayeemrmn
Copy link
Contributor

nayeemrmn commented Oct 10, 2019

Moved from denoland/deno_std#624.
Closes denoland/deno_std#623.

  • Move fs/path to the top-level.
  • Remove fs/path.ts.
  • Extract fs/expand_glob.ts from path/glob.ts.
@nayeemrmn

This comment has been minimized.

Copy link
Contributor Author

nayeemrmn commented Oct 10, 2019

cc @ry

std/fs/constants.ts Outdated Show resolved Hide resolved
std/fs/constants.ts Outdated Show resolved Hide resolved
std/fs/constants.ts Outdated Show resolved Hide resolved
std/fs/eol.ts Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn force-pushed the nayeemrmn:path-move branch from 778ab97 to 5a88413 Oct 16, 2019
@nayeemrmn

This comment has been minimized.

Copy link
Contributor Author

nayeemrmn commented Oct 16, 2019

@ry Is the current set of changes okay?

@ry
ry approved these changes Oct 16, 2019
Copy link
Collaborator

ry left a comment

Yes LGTM - sorry this took so long to get in

@ry ry merged commit f51dcc1 into denoland:master Oct 16, 2019
10 checks passed
10 checks passed
test macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2016
Details
test_std windows-2016
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@nayeemrmn nayeemrmn deleted the nayeemrmn:path-move branch Oct 16, 2019
@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Oct 16, 2019

This patch resulted in an increase in the bundle size of file_server.ts (512kb to 538kb) ... I'm not sure why.

Screen Shot 2019-10-16 at 3 34 49 PM

@nayeemrmn

This comment has been minimized.

Copy link
Contributor Author

nayeemrmn commented Oct 16, 2019

deno info std/http/file_server.ts on master~:

...
deps:
file:///mnt/c/Users/Nayeem/projects/deno/std/http/file_server.ts
  ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/http/server.ts
  │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/io/bufio.ts
  │ │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/io/util.ts
  │ │ │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/strings/mod.ts
  │ │ │ │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/strings/encode.ts
  │ │ │ │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/strings/decode.ts
  │ │ │ │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/strings/pad.ts
  │ │ │ └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path.ts
  │ │ │   └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/mod.ts
  │ │ │     ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/win32.ts
  │ │ │     │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/constants.ts
  │ │ │     │ └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/utils.ts
  │ │ │     │   └── file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/constants.ts
  │ │ │     ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/posix.ts
  │ │ │     │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/constants.ts
  │ │ │     │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/utils.ts
  │ │ │     └── file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path/constants.ts
  │ │ └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/testing/asserts.ts
  │ │   ├── file:///mnt/c/Users/Nayeem/projects/deno/std/fmt/colors.ts
  │ │   ├── file:///mnt/c/Users/Nayeem/projects/deno/std/testing/diff.ts
  │ │   └── file:///mnt/c/Users/Nayeem/projects/deno/std/testing/format.ts
  │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/textproto/mod.ts
  │ │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/io/bufio.ts
  │ │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/io/util.ts
  │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/http/http_status.ts
  │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/testing/asserts.ts
  │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/util/async.ts
  ├── file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path.ts
  └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/media_types/mod.ts
    └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/media_types/deps.ts
      ├── file:///mnt/c/Users/Nayeem/projects/deno/std/fs/path.ts
      └── file:///mnt/c/Users/Nayeem/projects/deno/std/media_types/db_c50e0d1.json

deno info std/http/file_server.ts on master:

...
deps:
file:///mnt/c/Users/Nayeem/projects/deno/std/http/file_server.ts
  ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/media_types/mod.ts
  │ └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/media_types/deps.ts
  │   ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/path/mod.ts
  │   │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/path/win32.ts
  │   │ │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/path/constants.ts
  │   │ │ └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/path/utils.ts
  │   │ │   └── file:///mnt/c/Users/Nayeem/projects/deno/std/path/constants.ts
  │   │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/path/posix.ts
  │   │ │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/path/constants.ts
  │   │ │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/path/utils.ts
  │   │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/path/constants.ts
  │   │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/path/glob.ts
  │   │ │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/path/globrex.ts
  │   │ │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/path/mod.ts
  │   │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/path/globrex.ts
  │   └── file:///mnt/c/Users/Nayeem/projects/deno/std/media_types/db_c50e0d1.json
  ├── file:///mnt/c/Users/Nayeem/projects/deno/std/path/mod.ts
  └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/http/server.ts
    ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/io/bufio.ts
    │ ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/io/util.ts
    │ │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/path/mod.ts
    │ │ └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/strings/mod.ts
    │ │   ├── file:///mnt/c/Users/Nayeem/projects/deno/std/strings/encode.ts
    │ │   ├── file:///mnt/c/Users/Nayeem/projects/deno/std/strings/decode.ts
    │ │   └── file:///mnt/c/Users/Nayeem/projects/deno/std/strings/pad.ts
    │ └─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/testing/asserts.ts
    │   ├── file:///mnt/c/Users/Nayeem/projects/deno/std/fmt/colors.ts
    │   ├── file:///mnt/c/Users/Nayeem/projects/deno/std/testing/diff.ts
    │   └── file:///mnt/c/Users/Nayeem/projects/deno/std/testing/format.ts
    ├─┬ file:///mnt/c/Users/Nayeem/projects/deno/std/textproto/mod.ts
    │ ├── file:///mnt/c/Users/Nayeem/projects/deno/std/io/bufio.ts
    │ └── file:///mnt/c/Users/Nayeem/projects/deno/std/io/util.ts
    ├── file:///mnt/c/Users/Nayeem/projects/deno/std/http/http_status.ts
    ├── file:///mnt/c/Users/Nayeem/projects/deno/std/testing/asserts.ts
    └── file:///mnt/c/Users/Nayeem/projects/deno/std/util/async.ts

master gains path/glob.ts and path/globrex.ts and loses fs/path.ts as expected... the rest is from other file changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.