Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DENO_DIR when saving the REPL history #3106

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@nayeemrmn
Copy link
Contributor

nayeemrmn commented Oct 11, 2019

Fixes #3104.

I still think it should be an entry in DenoDir, though.

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Oct 11, 2019

I still think it should be an entry in DenoDir, though.

What do you mean by that?

tools/repl_test.py Show resolved Hide resolved
@nayeemrmn

This comment has been minimized.

Copy link
Contributor Author

nayeemrmn commented Oct 11, 2019

@ry The DenoDir struct should have an entry corresponding to the history file. It models everything else in there.

@ry
ry approved these changes Oct 11, 2019
Copy link
Collaborator

ry left a comment

LGTM

@ry ry merged commit 04ed8d0 into denoland:master Oct 11, 2019
9 checks passed
9 checks passed
test macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2016
Details
test_std windows-2016
Details
test ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@nayeemrmn nayeemrmn deleted the nayeemrmn:repl-history branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.