Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --allow-net=:4500 #3115

Merged
merged 1 commit into from Oct 12, 2019

Conversation

@bartlomieju
Copy link
Contributor

bartlomieju commented Oct 12, 2019

Closes #2405

This PR adds functionality to expand host passed to --allow-net. If you pass "bare port" then it will be expanded to: 0.0.0.0:port, 127.0.0.1:port and localhost:port.

@ry
ry approved these changes Oct 12, 2019
Copy link
Collaborator

ry left a comment

LGTM - no comments

@ry ry merged commit b3331e8 into denoland:master Oct 12, 2019
9 checks passed
9 checks passed
test macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2016
Details
test_std windows-2016
Details
test ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@bartlomieju bartlomieju deleted the bartlomieju:feat-allow_net_expand_port branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.