Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deno.listenTLS #3152

Merged
merged 14 commits into from Oct 21, 2019

Conversation

@bartlomieju
Copy link
Contributor

bartlomieju commented Oct 19, 2019

Towards #3009

bartlomieju added 2 commits Oct 19, 2019
@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

bartlomieju commented Oct 19, 2019

Update: I got listenTLS and dialTLS to work together using self signed root certificate. I still need to clean it up and write better test 💪

@bartlomieju bartlomieju changed the title [WIP] feat: Deno.listenTLS feat: Deno.listenTLS Oct 19, 2019
@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

bartlomieju commented Oct 19, 2019

@ry ready for review

bartlomieju added 3 commits Oct 19, 2019
@bartlomieju bartlomieju force-pushed the bartlomieju:feat-listen_tls branch from 99f4164 to 11ce946 Oct 20, 2019
cli/js/lib.deno_runtime.d.ts Outdated Show resolved Hide resolved
cli/js/tls.ts Outdated Show resolved Hide resolved
cli/js/tls_test.ts Outdated Show resolved Hide resolved
cli/ops/tls.rs Outdated Show resolved Hide resolved
cli/tests/tls/README Outdated Show resolved Hide resolved
bartlomieju added 3 commits Oct 21, 2019
cli/js/tls_test.ts Outdated Show resolved Hide resolved
bartlomieju added 2 commits Oct 21, 2019
cli/js/tls_test.ts Show resolved Hide resolved
bartlomieju and others added 2 commits Oct 21, 2019
x
@ry
ry approved these changes Oct 21, 2019
Copy link
Collaborator

ry left a comment

LGTM - massive feature @bartlomieju !

Thank you on behalf of everyone who wants to run a TLS server in Deno : )

@ry ry merged commit 6c5a981 into denoland:master Oct 21, 2019
10 checks passed
10 checks passed
test macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2016
Details
test_std windows-2016
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@bartlomieju bartlomieju deleted the bartlomieju:feat-listen_tls branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.