Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --no-prompt flag #3183

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@kt3k
Copy link
Contributor

kt3k commented Oct 22, 2019

This PR removes --no-prompt flag and the feature of prompting the required permissions on demand.

Partially addresses #2767.

@kt3k kt3k force-pushed the kt3k:feature/no-no-prompt branch from 4371433 to f5004d1 Oct 22, 2019
@ry
ry approved these changes Oct 22, 2019
Copy link
Collaborator

ry left a comment

LGTM - going to just land this before anyone complains : )

I think this the right direction.

@ry ry merged commit 2804ba8 into denoland:master Oct 22, 2019
10 checks passed
10 checks passed
test macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2016
Details
test_std windows-2016
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@kt3k kt3k deleted the kt3k:feature/no-no-prompt branch Oct 23, 2019
@ry ry referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.