Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: fix BufReader.readString to actually return Deno.EOF at end #3191

Merged
merged 3 commits into from Oct 28, 2019

Conversation

@matey-jack
Copy link
Contributor

matey-jack commented Oct 23, 2019

Fixes #3190

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 23, 2019

CLA assistant check
All committers have signed the CLA.

@matey-jack matey-jack force-pushed the matey-jack:master branch from 668fe24 to b332394 Oct 23, 2019
@ry
ry approved these changes Oct 24, 2019
Copy link
Collaborator

ry left a comment

LGTM

Copy link
Collaborator

piscisaureus left a comment

lgtm

@piscisaureus piscisaureus reopened this Oct 28, 2019
@piscisaureus piscisaureus merged commit ff9df0c into denoland:master Oct 28, 2019
19 of 21 checks passed
19 of 21 checks passed
test macOS-10.14
Details
test macOS-10.14
Details
test_std macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2016 test windows-2016
Details
test windows-2019
Details
test windows-2019
Details
test_std windows-2016 test_std windows-2016
Details
test_std windows-2019
Details
test_std windows-2019
Details
test ubuntu-16.04
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.