Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish source tarballs for releases #3203

Merged
merged 3 commits into from Oct 25, 2019

Conversation

@chrmoritz
Copy link
Contributor

chrmoritz commented Oct 25, 2019

Fixes: #3199

This PR adds the creation of source tarballs to the release workflow, because the automatically generated tarballs by GitHub doesn't contain any files from submodules (see #3199 ).

Tarball size is down to ~48MB atm, after exclude all .git* files, the big typescript tests directory and all format and lint tools from third_party (everything except v8 and depot_tools there) to reduce tarball size.

I've confirmed locally that cargo build (including setup.py) and cargo test are still working from withing the extracted source tarball.

@ry
ry approved these changes Oct 25, 2019
Copy link
Collaborator

ry left a comment

LGTM

@ry ry merged commit 1a86264 into denoland:master Oct 25, 2019
10 checks passed
10 checks passed
test macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2019
Details
test_std windows-2019
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@chrmoritz chrmoritz referenced this pull request Oct 28, 2019
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.