Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EOF symbol #3244

Merged
merged 2 commits into from Oct 31, 2019

Conversation

@kt3k
Copy link
Contributor

kt3k commented Oct 31, 2019

At the time of #2591, it was not possible to make EOF an unique symbol, but it now seems possible to do it.

This addresses a TODO comment in //cli/js/io.ts.

kt3k added 2 commits Oct 25, 2019
@ry
ry approved these changes Oct 31, 2019
Copy link
Collaborator

ry left a comment

LGTM

@ry ry merged commit 4f8c936 into denoland:master Oct 31, 2019
10 checks passed
10 checks passed
test macOS-10.14
Details
test_std macOS-10.14
Details
test windows-2019
Details
test_std windows-2019
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@kt3k kt3k deleted the kt3k:feature/symbol-eof branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.