Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude prebuilt from deno_src release #3272

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@hayd
Copy link
Contributor

hayd commented Nov 5, 2019

Copy link
Contributor

chrmoritz left a comment

One small addition, otherwise LGTM 👍

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Keeping a empty node_modules was required, because the test relied on the node_modules symlink to point to a valid target. This is no longer the case since #3247, so we can remove this workaround too.

Co-Authored-By: Christian Moritz <chrmoritz@users.noreply.github.com>
@chrmoritz

This comment has been minimized.

Copy link
Contributor

chrmoritz commented Nov 5, 2019

Another side note: It is common practice to put the version number the the release asserts name too (e.g. deno_v0.23.0_linux_x64.gz or deno_v0.23.0_src.tar.gz). Not having one in it currently breaks homebrew automatic version detection (and the formula requires an explicit version number because of that). But implementing this would require some significant changes to deno_install too.

@ry
ry approved these changes Nov 5, 2019
Copy link
Collaborator

ry left a comment

LGTM

@ry ry merged commit 92b8674 into denoland:master Nov 5, 2019
10 checks passed
10 checks passed
test macOS-latest
Details
test_std macOS-latest
Details
test windows-2019
Details
test_std windows-2019
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.