Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 3.7 #3275

Merged
merged 1 commit into from Nov 13, 2019
Merged

Update to TypeScript 3.7 #3275

merged 1 commit into from Nov 13, 2019

Conversation

@kitsonk
Copy link
Contributor

kitsonk commented Nov 6, 2019

Also, update assert() and remove not null assertions where possibly in cli. Lots of the not null assertions need to be removed in std though.

Closes #3273

@kitsonk

This comment has been minimized.

Copy link
Contributor Author

kitsonk commented Nov 6, 2019

BAH! It appears prettier doesn't support the TypeScript 3.7 syntax features. It is fixed in master of prettier, but they haven't released it yet.

@kitsonk

This comment has been minimized.

Copy link
Contributor Author

kitsonk commented Nov 6, 2019

It looks like prettier 1.19 is imminent which should include all the 3.7 syntax fixes, so I guess we should hold off on this until that is released.

@zekth

This comment has been minimized.

Copy link
Contributor

zekth commented Nov 7, 2019

Could you raise an issue for the problematic asserts in std?

@axetroy

This comment has been minimized.

Copy link
Contributor

axetroy commented Nov 9, 2019

It looks like prettier 1.19 is imminent which should include all the 3.7 syntax fixes, so I guess we should hold off on this until that is released.

Prettier@1.19.0 has been released now.

@axetroy axetroy mentioned this pull request Nov 9, 2019
@kitsonk

This comment has been minimized.

Copy link
Contributor Author

kitsonk commented Nov 9, 2019

Ok this now includes prettier 1.19 in third_party/node_modules as well as re-lints the codebase. There was a bit of churn with this version of prettier, but mainly it was fixing some bugs that were there, so it ends up with better formatted code.

If it passes it CI it should be ready to go @ry

@kitsonk kitsonk force-pushed the kitsonk:ts_37 branch 2 times, most recently from 324e011 to 83607d6 Nov 10, 2019
@kitsonk

This comment has been minimized.

Copy link
Contributor Author

kitsonk commented Nov 13, 2019

@ry ok, I think I have fixed everything and this PR is ready now

@ry
ry approved these changes Nov 13, 2019
Copy link
Collaborator

ry left a comment

LGTM - thank you @kitsonk !

Update to prettier 1.19

Also, update `assert()` and remove not null assertions where possibly
in `cli`.

Closes #3273
@ry ry force-pushed the kitsonk:ts_37 branch from e1d8ad2 to 8e79966 Nov 13, 2019
@ry ry merged commit 9837d32 into denoland:master Nov 13, 2019
10 checks passed
10 checks passed
test macOS-latest
Details
test_std macOS-latest
Details
test windows-2019
Details
test_std windows-2019
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
ry added a commit to ry/deno that referenced this pull request Nov 13, 2019
Mistakenly re-enabled in denoland#3275.
piscisaureus added a commit that referenced this pull request Nov 13, 2019
Mistakenly re-enabled in #3275.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.