Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix js/url #3316

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@zhmushan
Copy link
Contributor

zhmushan commented Nov 11, 2019

> new URL(“about:blank”)

expected:

{ href: “about:blank”, protocol: “about:”, origin: “null”, ... }

actual:

{ href: “about://blank”, protocol: “about:”, origin: “about://”, ... }

> new URL(“0.0.0.0:8080”)

expected: Error
actual:

{ href: “0.0.0.0://8080”, ... }
@ry
ry approved these changes Nov 12, 2019
Copy link
Collaborator

ry left a comment

LGTM

@ry ry merged commit 0f33bf6 into denoland:master Nov 12, 2019
10 checks passed
10 checks passed
test macOS-latest
Details
test_std macOS-latest
Details
test windows-2019
Details
test_std windows-2019
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@zhmushan zhmushan deleted the zhmushan:fixurl branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.