Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Fix error handling in walk() #3318

Merged
merged 3 commits into from Nov 15, 2019

Conversation

@nayeemrmn
Copy link
Contributor

nayeemrmn commented Nov 11, 2019

Fixes #3315. Cleans up std/fs/walk.ts.

std: Fix error handling in walk()

- Remove WalkOptions::onError().
- Return the error in assertThrows().
@CreatCodeBuild

This comment has been minimized.

Copy link

CreatCodeBuild commented Nov 12, 2019

Though I raised this issue # 3315, I assume a maintainer should review?

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Nov 13, 2019

@nayeemrmn Looks good! thanks! Please merge master

@nayeemrmn nayeemrmn force-pushed the nayeemrmn:fs-walk branch from 77658a2 to 4c863df Nov 13, 2019
@ry
ry approved these changes Nov 15, 2019
Copy link
Collaborator

ry left a comment

LGTM - sorry for the delay

@ry ry merged commit 7901038 into denoland:master Nov 15, 2019
10 checks passed
10 checks passed
test macOS-latest
Details
test_std macOS-latest
Details
test windows-2019
Details
test_std windows-2019
Details
test ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
test_std ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@nayeemrmn nayeemrmn deleted the nayeemrmn:fs-walk branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.