Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: align deno_http and node_http response #3484

Merged
merged 1 commit into from Dec 12, 2019
Merged

benchmark: align deno_http and node_http response #3484

merged 1 commit into from Dec 12, 2019

Conversation

kevinkassimo
Copy link
Contributor

Align deno_http and node_http test server response to have similar headers and sizes (s.t. benchmark reflects more correctly).

After this change:
curl -i on Node:

HTTP/1.1 200 OK
Date: Thu, 12 Dec 2019 01:31:15 GMT
Connection: keep-alive
Content-Length: 11

Hello World

curl -i on Deno:

HTTP/1.1 200 OK
date: Thu, 12 Dec 2019 01:30:58 GMT
connection: keep-alive
content-length: 11

Hello World

ry
ry approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ry ry merged commit d146d45 into denoland:master Dec 12, 2019
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@kevinkassimo @bartlomieju
benchmark: align deno_http and node_http response (denoland#3484)
edf8c40
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@kevinkassimo @ry
benchmark: align deno_http and node_http response (denoland/deno#3484)
b9a174c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kevinkassimo @ry
benchmark: align deno_http and node_http response (denoland/deno#3484)
556e93a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kevinkassimo @caspervonb
benchmark: align deno_http and node_http response (denoland/deno#3484)
63813e5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kevinkassimo @caspervonb
benchmark: align deno_http and node_http response (denoland/deno#3484)
f3820c8
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kevinkassimo @caspervonb
benchmark: align deno_http and node_http response (denoland/deno#3484)
9e8a943
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kevinkassimo @caspervonb
benchmark: align deno_http and node_http response (denoland/deno#3484)
8437d8f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kevinkassimo @caspervonb
benchmark: align deno_http and node_http response (denoland/deno#3484)
e2ba8dd
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kevinkassimo @denobot
benchmark: align deno_http and node_http response (denoland/deno#3484)
5269394
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@kevinkassimo @denobot
benchmark: align deno_http and node_http response (denoland/deno#3484)
8223127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinkassimo @ry